github-actions[bot] commented on code in PR #68190: URL: https://github.com/apache/doris/pull/68190#discussion_r4045708507
########## fe/fe-core/src/test/java/org/apache/doris/planner/LocalShuffleNodeCoverageTest.java: ########## @@ -28,13 +30,16 @@ import org.apache.doris.analysis.SortInfo; import org.apache.doris.analysis.TupleDescriptor; import org.apache.doris.analysis.TupleId; +import org.apache.doris.catalog.FunctionName; Review Comment: [P1] Import FunctionName from the analysis package `FunctionCallExpr#getFnName()` returns `org.apache.doris.analysis.FunctionName`, and this branch contains no `org.apache.doris.catalog.FunctionName`. As written, this changed test cannot compile, so none of the new aggregation coverage can run. Please import the existing analysis class instead. ```suggestion import org.apache.doris.analysis.FunctionName; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
