github-actions[bot] commented on code in PR #68241:
URL: https://github.com/apache/doris/pull/68241#discussion_r4056104760
##########
fs_brokers/cdc_client/src/main/java/org/apache/doris/cdcclient/sink/DorisBatchStreamLoad.java:
##########
@@ -572,6 +572,15 @@ public void commitOffset(
taskId);
return;
}
+ JsonNode data = root.get("data");
+ JsonNode msg = root.get("msg");
+ if (data != null && data.isTextual()
Review Comment:
Both exact-head CDC jobs stop in Maven `validate` because Spotless rejects
this wrapping, so the new test never compiles or runs. Please apply the
module's AOSP formatter to split `data != null` and `msg != null` onto their
own condition lines, then rerun the CDC build/tests.
##########
fs_brokers/cdc_client/src/main/java/org/apache/doris/cdcclient/sink/DorisBatchStreamLoad.java:
##########
@@ -572,6 +572,15 @@ public void commitOffset(
taskId);
return;
}
+ JsonNode data = root.get("data");
+ JsonNode msg = root.get("msg");
+ if (data != null && data.isTextual()
+ && StringUtils.isNotBlank(data.asText())) {
+ reason = data.asText();
Review Comment:
The decoded FE cause can still be erased by this retry loop. A data-quality
rejection pauses the job and cancels the running task, so attempt 1 reaches
this branch with the actionable `code=1` message; attempt 2 then hits
`StreamingInsertJob.commitOffset()`'s canceled-task early return, which the
endpoint serializes as `code=0`. This method returns success, and
`PipelineCoordinator` removes task progress/logs successful processing even
though the offset was rejected. Please keep a state-changing application
rejection from being converted into later no-op success (for example, make it
non-retryable or have FE return the persisted rejection), and add a
failure-then-canceled-success test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
