yiguolei commented on code in PR #67784: URL: https://github.com/apache/doris/pull/67784#discussion_r4056277940
########## be/src/format/table/paimon/paimon_arrow_block_convertor.cpp: ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "format/table/paimon/paimon_arrow_block_convertor.h" + +#include <arrow/array/builder_base.h> +#include <arrow/type.h> + +namespace doris::paimon { +#include "common/compile_check_begin.h" + +Status PaimonArrowBlockConvertor::write_column(const std::shared_ptr<const IDataType>& type, + const DataTypeSerDe& serde, const IColumn& column, + const NullMap* null_map, + const std::shared_ptr<arrow::Field>& field, + arrow::ArrayBuilder* array_builder, int64_t start, + int64_t end, const cctz::time_zone& ctz) const { + // This adapter dereferences Arrow declarations that are intentionally forward-declared by + // its public header, so keep the complete definitions local to this implementation file. + return serde.write_column_to_paimon_arrow(type, column, null_map, + field->WithType(array_builder->type()), array_builder, + start, end, ctz); +} + +const PaimonArrowBlockConvertor& paimon_arrow_block_convertor() { Review Comment: 不要增加这种工具类 后续如果我们的paimon arrow convertor 里增加啥参数的话，相关的代码都需要变动 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
