JNSimba opened a new pull request, #68270:
URL: https://github.com/apache/doris/pull/68270
### What problem does this PR solve?
Issue Number: DORIS-29112, DORIS-29141, DORIS-29143, DORIS-29156
Problem Summary:
Streaming jobs could leak the job write lock after a failed cloud commit,
partially mutate job state when ALTER validation failed, reset data-quality
sampling for unrelated property changes, and accept source-incompatible CDC
offsets.
This change releases the per-attempt lock when a cloud transaction is not
committed, validates ALTER inputs before mutating source state, resets cloud
offset before changing local offset state, preserves the sampling window unless
`max_interval` changes, and validates PostgreSQL/MySQL/OceanBase offset
locations including GTID-only recovery.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
Unit tests were not run because the local FE test bootstrap is blocked by
thrift compiler 0.16.0 while the project uses libthrift 0.24.0.
- Behavior changed:
- [ ] No.
- [x] Yes. ALTER rejects source-incompatible offsets and preserves
existing job state when validation fails; unrelated property changes retain the
current data-quality sampling window.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
