englefly commented on code in PR #68182:
URL: https://github.com/apache/doris/pull/68182#discussion_r4056308767
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ConcatWs.java:
##########
@@ -35,7 +36,7 @@
* ScalarFunction 'concat_ws'. This class is generated by GenerateFunction.
*/
public class ConcatWs extends ScalarFunction
- implements ExplicitlyCastableSignature {
+ implements ExplicitlyCastableSignature, NullToNonNullFunction {
Review Comment:
1. 只有当分隔符是null 时, concat_ws 的返回值才是null, 并不是把null 值转化为 非null 值.
所以 concat_ws 不满足 NullToNonNullFunction 的含义.
2. concat_ws 如果分隔符参数不是null, 也可以下推
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
