morningman commented on PR #68220: URL: https://github.com/apache/doris/pull/68220#issuecomment-5750242350
Addressed in 400194c4517. Per finding: - **[P1] Refuse after post-publication initialization failures** - fixed: a load that throws now records a failed state and stops what it had published before the latch is released; every answer refuses. Test added (`testALoadThatFailsAfterPublishingRefusesEverything`). - **[P1] Do not treat an unavailable user store as no groups** - not changed: it is the semantics of Ranger's own `use.rangerGroups`, the last-known store is already retained by Ranger across failed refreshes and engine rebuilds, and fail-closed would refuse every check on a Ranger Admin that never serves a user store. Added a WARN when the load ends with policies but no store. Details in the thread. - **[P1] Publish the user-store snapshot atomically** - not changed: the first store is downloaded on the loading thread before the latch is released (a happens-before edge for the case that matters), a refresh swaps one reference to an all-`final` object, and the read is the one Ranger's own request processing performs. Details in the thread. - **[P2] Check the closed fence before the unbounded load wait** - fixed: the controller's three waits give up as soon as the controller is closed (`awaitLoaded(BooleanSupplier)`), and refuse through the existing fence. Tests added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
