yujun777 commented on PR #68180: URL: https://github.com/apache/doris/pull/68180#issuecomment-5772676569
**Re: the changes requested in this review** — the P2 is fixed in 253120b64b5; the inline thread has the detail. The window branch now classifies the change on the effective (normalized) window instead of the stored values, and requires a complete baseline rebuild only when a base partition can come *back* into what the MV maintains: a removed limit, or a wider one. A window that starts applying, a narrower one and one that describes the same set no longer force it, so a strict INCREMENTAL refresh after a narrowing is not rejected and an AUTO refresh does not rebuild the whole MV. Where the two configurations are in different units or date formats -- not comparable without a clock -- the change is treated as one that may widen; `now()` stays out of the decision, since an answer on the wrong side of a unit boundary would be wrong in the unsafe direction. Two things stated rather than left to be inferred: 1. A narrowing carries no generation bump either, deliberately: `schemaChangeVersion` makes an in-flight task *fail* at its next barrier write rather than discarding its result, and for a narrowing that costs a failed refresh to prevent nothing -- what such a task publishes is rows for partitions the next partition sync drops, with their IVM offsets. 2. The three tests that set the window no longer release a barrier: a window that starts applying records none now, so their assertions are carried by the selection they are about rather than by the ALTER. Verification on this head: `IvmBaselineRebuildTest` 37/37, `MTMVPropertyUtilTest` 13/13, `MTMVTest` 23/23, `MTMVPartitionUtilTest` 18/18, `checkstyle:check` clean, and the `mtmv_p0/ivm` suites test_ivm_partition_sync_limit, test_ivm_partition_sync_limit_with_window, test_ivm_baseline_marker_scope, test_ivm_partition_baseline_rebuild, test_ivm_partition_baseline_rebuild_dup_keys, test_ivm_drop_referenced_column_baseline_rebuild, test_ivm_partition_drop_live_delta, test_ivm_replace_table_reconcile, test_ivm_replace_stream_cleanup and test_ivm_drop_column_fallback_reason green on a local cluster built from it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
