yujun777 commented on PR #68390: URL: https://github.com/apache/doris/pull/68390#issuecomment-5790367072
**P2-8 (publish the rebuilt plan signature on the direct COMPLETE path) — not taken, and here is the evidence.** I implemented it: widening `capturePlanSignature` to `mtmv.isIvm() && refreshMode == COMPLETE`. It is not a diagnostic change — it is a data-correctness regression. Three suites start writing their delta twice: - `test_ivm_snapshot` — `partition_after_incr`: `1 / 55.00` becomes `2 / 110.00` - `test_ivm_bitmap_agg_2` — `scalar_delete_all_incremental` - `test_ivm_agg_array_1` — `list_after_group_delete` Bisected and isolated: reverting every other change from this round keeps them red, and restoring everything while reverting only this one makes them green again. The mechanism is the one the finding proposes, read the other way round: publishing the fresh signature lets the *next* refresh take the incremental path instead of the `PLAN_SIGNATURE_MISMATCH` -> COMPLETE fallback, and that incremental re-applies rows the COMPLETE had just rebuilt. The "second COMPLETE" is therefore load-bearing protection, not the wasted work the finding describes. Fixing what the finding is really after needs the incremental path's offset/baseline handling understood first, so I have left the condition as it was rather than widen it. Recording it here so it is not lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
