gavinchou commented on code in PR #68457:
URL: https://github.com/apache/doris/pull/68457#discussion_r4088579793
##########
cloud/src/meta-store/keys.cpp:
##########
@@ -1244,11 +1252,13 @@ bool decode_snapshot_ref_key(std::string_view* in,
std::string* instance_id,
}
// Decode ref_instance_id
- if (ref_instance_id && decode_bytes(in, ref_instance_id) != 0) {
+ std::string ignored_ref_instance_id;
+ if (decode_bytes(in, ref_instance_id != nullptr ? ref_instance_id :
&ignored_ref_instance_id) !=
+ 0) {
return false;
}
- return true;
+ return in->empty();
Review Comment:
should `return true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
