github-actions[bot] commented on code in PR #68439: URL: https://github.com/apache/doris/pull/68439#discussion_r4089845197
########## fe/fe-core/src/test/java/org/apache/doris/nereids/trees/expressions/functions/scalar/DictGetManyTest.java: ########## @@ -0,0 +1,172 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.scalar; + +import org.apache.doris.catalog.Column; +import org.apache.doris.catalog.Env; +import org.apache.doris.catalog.Type; +import org.apache.doris.dictionary.Dictionary; +import org.apache.doris.dictionary.DictionaryManager; +import org.apache.doris.dictionary.LayoutType; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.parser.NereidsParser; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.literal.ArrayLiteral; +import org.apache.doris.nereids.trees.expressions.literal.BigIntLiteral; +import org.apache.doris.nereids.trees.expressions.literal.NullLiteral; +import org.apache.doris.nereids.trees.expressions.literal.StringLiteral; +import org.apache.doris.nereids.trees.expressions.literal.StructLiteral; +import org.apache.doris.nereids.types.BigIntType; +import org.apache.doris.nereids.types.IntegerType; +import org.apache.doris.nereids.types.StructField; +import org.apache.doris.nereids.types.StructType; +import org.apache.doris.nereids.types.TimeStampNsType; + +import com.google.common.collect.ImmutableList; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.mockito.MockedStatic; +import org.mockito.Mockito; + +public class DictGetManyTest { + @Test + public void testRejectNullQueryKeyStruct() { + StructType structType = new StructType(ImmutableList.of( + new StructField("k", IntegerType.INSTANCE, true, ""))); + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), + new ArrayLiteral(ImmutableList.of(new StringLiteral("value"))), + new Cast(new NullLiteral(), structType)); + + AnalysisException exception = Assertions.assertThrows(AnalysisException.class, + function::checkLegalityBeforeTypeCoercion); + Assertions.assertEquals("dict_get_many() query_key_values argument cannot be NULL", + exception.getMessage()); + } + + @Test + public void testAllowNullFieldInNonNullQueryKeyStruct() { + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), + new ArrayLiteral(ImmutableList.of(new StringLiteral("value"))), + new StructLiteral(ImmutableList.of(new NullLiteral(IntegerType.INSTANCE)))); + + Assertions.assertDoesNotThrow(function::checkLegalityBeforeTypeCoercion); + } + + @Test + public void testRejectNonArrayValueColumnNames() { + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), new StringLiteral("value"), + new StructLiteral(ImmutableList.of(new BigIntLiteral(1)))); + + assertRejected(function, "second argument must be a constant ARRAY<VARCHAR>"); + } + + @Test + public void testRejectNonStructQueryKeyValues() { + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), + new ArrayLiteral(ImmutableList.of(new StringLiteral("value"))), new BigIntLiteral(1)); + + assertRejected(function, "third argument must be a STRUCT"); + } + + @Test + public void testRejectNonStringValueColumnNames() { + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), + new ArrayLiteral(ImmutableList.of(new BigIntLiteral(1))), + new StructLiteral(ImmutableList.of(new BigIntLiteral(1)))); + + assertRejected(function, "second argument must be a constant ARRAY<VARCHAR>"); + } + + @Test + public void testRejectNullValueColumnNameFromParser() { + ArrayLiteral valueColumnNames = (ArrayLiteral) new NereidsParser().parseExpression("['value_col', NULL]"); + Assertions.assertTrue(valueColumnNames.getValue().get(1) instanceof NullLiteral); + Assertions.assertTrue(valueColumnNames.getValue().get(1).getDataType().isStringLikeType()); + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), valueColumnNames, + new StructLiteral(ImmutableList.of(new BigIntLiteral(1)))); + + assertRejected(function, "second argument cannot contain NULL"); + } + + @Test + public void testRejectQueryKeyStructWithMismatchedFieldCount() throws Exception { + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), + new ArrayLiteral(ImmutableList.of(new StringLiteral("value"))), + new StructLiteral(ImmutableList.of(new BigIntLiteral(1), new BigIntLiteral(2)))); + Env env = Mockito.mock(Env.class); + DictionaryManager dictionaryManager = Mockito.mock(DictionaryManager.class); + Dictionary dictionary = Mockito.mock(Dictionary.class); + Column valueColumn = Mockito.mock(Column.class); + Mockito.when(env.getDictionaryManager()).thenReturn(dictionaryManager); + Mockito.when(dictionaryManager.getDictionary("db", "dict")).thenReturn(dictionary); + Mockito.when(dictionary.getLayout()).thenReturn(LayoutType.HASH_MAP); + Mockito.when(dictionary.getDicColumns()).thenReturn(ImmutableList.of()); + Mockito.when(dictionary.getOriginColumn("value")).thenReturn(valueColumn); + Mockito.when(valueColumn.getName()).thenReturn("value"); + Mockito.when(valueColumn.getType()).thenReturn(Type.INT); + Mockito.when(valueColumn.getComment()).thenReturn(""); + Mockito.when(dictionary.getKeyColumnTypes()).thenReturn(ImmutableList.of(IntegerType.INSTANCE)); + + try (MockedStatic<Env> mockedEnv = Mockito.mockStatic(Env.class)) { + mockedEnv.when(Env::getCurrentEnv).thenReturn(env); + + AnalysisException exception = Assertions.assertThrows(AnalysisException.class, + function::customSignatureDict); + Assertions.assertEquals( + "dict_get_many() query_key_values field count must match dictionary key count", + exception.getMessage()); + } + } + + @Test + public void testRejectQueryKeyWhenImplicitCastIsNotSupported() throws Exception { + DictGetMany function = new DictGetMany(new StringLiteral("db.dict"), + new ArrayLiteral(ImmutableList.of(new StringLiteral("value"))), + new StructLiteral(ImmutableList.of(new Cast(new BigIntLiteral(0), TimeStampNsType.INSTANCE)))); + Env env = Mockito.mock(Env.class); Review Comment: **[P1] Construct this STRUCT with an expression-capable node** `StructLiteral` takes a `List<Literal>`, but `Cast` extends `Expression` directly, so this argument cannot type-check and FE test compilation stops before the new assertion runs. `CreateStruct` accepts general expressions and preserves this test's `STRUCT<TIMESTAMP_NS>` input. ```suggestion new CreateStruct(new Cast(new BigIntLiteral(0), TimeStampNsType.INSTANCE))); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
