github-actions[bot] commented on code in PR #68487:
URL: https://github.com/apache/doris/pull/68487#discussion_r4092184763
##########
be/src/exprs/function/function_encryption.cpp:
##########
@@ -103,6 +103,10 @@ class FunctionEncryptionAndDecrypt : public IFunction {
return get_variadic_argument_types_impl().size();
}
+ ColumnNumbers get_arguments_that_are_always_constant() const override {
Review Comment:
[P1] Enforce semantic constness rather than the block's column shape
This hook ultimately checks only `is_column_const` on the current execution
block, which is not the same as the SQL expression being constant. Hudi and
MaxCompute materialize projected partition keys with
`create_column_const(...)`, and a fused scan projection evaluates `VSlotRef`
before the projection result is expanded to a full column. Thus a table
partitioned by `mode` can run `AES_ENCRYPT(payload, key, iv, mode)` over
`AES_128_CBC` and `AES_256_CBC` partitions: every block passes this check while
the mode varies across the query. The new OLAP regression misses this
physical-const slot path. Please validate the mode expression's semantic
constness (with a BE context-metadata backstop for old-FE plans) and cover a
partition-key mode that differs across two splits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
