OIiveirra commented on PR #68458: URL: https://github.com/apache/doris/pull/68458#issuecomment-5813817722
## Review follow-up ### Jira requirement The reported issue is a Paimon Decimal schema evolution case: - legacy file: `DECIMAL(5,2)` with value `1.20` - current schema: `DECIMAL(6,3)` - expected from JNI: `1.200` - reported master behavior: `0.120` The code change makes `PaimonColumnValue#getDecimal()` use the Paimon `DecimalType` precision and scale when decoding the record value. ### Simulated validation - `PaimonColumnValueTest`: passed (`10` tests, `0` failures) - Paimon Decimal scale evolution regression: passed - V1 native: `1.200` - V2 native: `1.200` - forced JNI: `1.200` - The focused unit test fails with the previous implementation and passes with this implementation. ### Validation boundary The original Jira warehouse/files were not available. The local end-to-end fixture also returns `1.200` on the baseline, so baseline reproduction of `0.120` could not be established locally. This review therefore validates the fix against the simulated schema-evolution behavior and the affected Decimal decoding method; it does not claim reproduction of the submitter's original environment. ### Conclusion Within the available simulated reproduction, the PR behavior is correct and the targeted tests pass. The real Jira fixture should be rerun when the original Paimon files or catalog configuration become available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
