dustinCodes84600 commented on PR #68462:
URL: https://github.com/apache/doris/pull/68462#issuecomment-5838386939
`std::stoll` accepts a valid numeric prefix, so `safe_stoll("123junk", ...)`
still succeeds with 123. Since these are supposed to reject malformed headers,
could capture the parsed position and require it to equal `input.size()`, plus
add a trailing-garbage test?
btw, made a quick walkthrough while reading this PR:
https://flyovers.dev/flyover/3367ce2a-8aa1-4082-9ea6-5253189a868b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
