LuciferYang commented on code in PR #68521:
URL: https://github.com/apache/doris/pull/68521#discussion_r4111614539
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -1153,10 +1153,11 @@ Status
SegmentIterator::_get_row_ranges_from_conditions(RowRanges* condition_row
_opts.target_cast_type_for_variants, _opts)) {
continue;
}
- if (_segment->is_tso_placeholder_col(cid, *_schema, _opts)) {
- // skip untrustworthy tso placeholder zonemap
- // if possible already be pruned as a whole before,
- // so just skip
+ if (_segment->placeholder_effective_value(cid, *_schema,
_opts).has_value()) {
+ // A hidden placeholder column (version / commit-tso /
binlog-tso) holds one
Review Comment:
Fixed in 6c575b3573c. Bloom-filter pruning (in
`_get_row_ranges_from_conditions`) and inverted-index pruning
(`_apply_inverted_index_on_column_predicate`) now skip columns with a
`placeholder_effective_value`: the bloom loop `continue`s the column, and the
inverted path keeps the predicate in `remaining_predicates` for read-time
evaluation against the substituted value.
Confirmed reachable and now correct: with an inverted index AND
`bloom_filter_columns` on `__DORIS_VERSION_COL__`, `WHERE __DORIS_VERSION_COL__
= <real version>` returns all rows (new `version_col_indexed_match` regression
case) instead of being pruned to empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
