github-actions[bot] commented on code in PR #68606:
URL: https://github.com/apache/doris/pull/68606#discussion_r4129386830
##########
be/src/exprs/aggregate/aggregate_function_simple_factory.cpp:
##########
@@ -123,7 +122,6 @@ AggregateFunctionSimpleFactory&
AggregateFunctionSimpleFactory::instance() {
register_aggregate_function_avg_weighted(instance);
register_aggregate_function_histogram(instance);
register_aggregate_function_linear_histogram(instance);
- register_aggregate_function_map_agg(instance);
Review Comment:
[P1] Preserve reads of persisted map_agg_v1 aggregate states
A table created before this change with an `AGG_STATE<map_agg_v1(...)>`
column retains that name in its segment metadata. On a later scan,
`ColumnReader::create_agg_state` constructs `DataTypeAggState`, whose factory
lookup now returns null and throws `DataTypeAggState function get failed`, so
those existing rows become unreadable. An old FE sending v1 fragments to an
upgraded BE also fails during a rolling upgrade. Please keep a compatible BE
path for stored v1 states and old fragments, with a pre-upgrade segment fixture
that verifies the read path. V1/v2 intermediate encodings differ, so a bare
name alias needs explicit compatibility proof.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
