Gabriel39 commented on code in PR #68614:
URL: https://github.com/apache/doris/pull/68614#discussion_r4130893116
##########
be/src/format/arrow/arrow_row_batch.cpp:
##########
@@ -138,7 +138,9 @@ Status convert_to_arrow_type(const DataTypePtr& origin_type,
std::shared_ptr<arrow::DataType> item_type;
RETURN_IF_ERROR(convert_to_arrow_type(type_arr->get_nested_type(),
&item_type, timezone,
datetime_naive));
- *result = std::make_shared<arrow::ListType>(item_type);
+ // Arrow stores metadata on fields, so implicit child fields lose the
Doris logical type.
+ *result =
std::make_shared<arrow::ListType>(create_arrow_field_with_metadata(
Review Comment:
Fixed in 46c6a9b3b6.
Fixed with capability negotiation and FE schema normalization.
- Old FEs omit the optional result-sink flag, so upgraded BEs retain the
legacy metadata layout in both parallel and non-parallel result sinks. Schema
fetches and local/remote DoGet use that same buffered schema. This covers the
supported BE-first rolling upgrade order.
- Upgraded FEs opt into extended metadata and fill only missing doris_type
markers from the planned Doris output types before both comparison and
advertisement. Mixed BE versions therefore advertise identical metadata in
either order. Physical properties, conflicting markers and unrelated metadata
remain subject to strict equality.
- Added tests for mixed/all-old/all-new endpoints, rejected schema
differences, capability negotiation, exact legacy schemas for all five logical
types, LARGEINT map keys, and legacy IPC/value compatibility.
Validation: 13 FE tests passed, FE Checkstyle passed, and the pre-fix FE
reproduces the reported schema mismatch. All 25 targeted BE ASAN tests passed,
including the five new legacy-schema cases and legacy value/IPC checks. No live
rolling-upgrade cluster test is claimed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
