yiguolei commented on code in PR #16594:
URL: https://github.com/apache/doris/pull/16594#discussion_r1102727049
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -688,8 +688,9 @@ Status VNodeChannel::close_wait(RuntimeState* state) {
}
// waiting for finished, it may take a long time, so we couldn't set a
timeout
- while (!_add_batches_finished && !_cancelled) {
- std::this_thread::sleep_for(std::chrono::milliseconds(1));
+ while (!_add_batches_finished && !_cancelled && !state->is_cancelled()) {
+ // std::this_thread::sleep_for(std::chrono::milliseconds(1));
+ bthread_usleep(1000);
Review Comment:
Please not use bhtread here, @chenlinzhong will add pthread pool after
internal_service.cpp for every brpc request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]