OIiveirra commented on PR #68585: URL: https://github.com/apache/doris/pull/68585#issuecomment-5891104495
Addressed both P2 issues and pushed the fixes to this PR. 1. Relative Hadoop XML resource paths: reused `StorageAdapter.withHadoopConfigDir()` in the `FileSystemFactory` binding and filesystem creation paths, so CREATE/ALTER validation and actual filesystem access both resolve resources under `Config.hadoop_config_dir`. 2. Cleanup after failed CREATE validation: `CatalogMgr.createCatalogInternal()` now calls `catalog.onCreateFailure()` when post-creation property validation throws, releasing the connector, HMS client pool, and managed metadata cache. Validation: - FE `CatalogFactoryTest`: passed - FE Checkstyle and build: passed - `external_table_p0/test_catalog_ddl`: passed (1 suite, 0 failed) - Personal FE/BE deployment and health check: passed Fix commit: `36555a965a1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
