manesioz commented on code in PR #68506:
URL: https://github.com/apache/doris/pull/68506#discussion_r4136837243
##########
fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java:
##########
@@ -837,7 +837,7 @@ public Long getValue() {
HTTP_COUNTER_COPY_INFO_QUERY_REQUEST = new
LongCounterMetric("http_copy_into_query_request_total",
MetricUnit.REQUESTS, "http copy into total query request");
DORIS_METRIC_REGISTER.addMetrics(HTTP_COUNTER_COPY_INFO_QUERY_REQUEST);
- HTTP_COUNTER_COPY_INFO_QUERY_ERR = new
LongCounterMetric("http_copy_into_upload_err_total",
+ HTTP_COUNTER_COPY_INFO_QUERY_ERR = new
LongCounterMetric("http_copy_into_query_err_total",
Review Comment:
Fixed. A missing fileName now counts one error, and I removed the extra
increment after the catch blocks. Every failed upload exit now counts exactly
once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
