r33s3n6 opened a new issue, #68719:
URL: https://github.com/apache/doris/issues/68719

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   ### Version
   
   4.1.4 (doris-4.1.4-rc04-ad35a140c7f), single FE + single BE
   
   ### What's Wrong?
   
   `ceil(-0.5)` on a DOUBLE is -0 when BE computes it and +0 when FE folds the 
constant, so `signbit(ceil(...))` is 1 and 0. `round(-0.4)` behaves the same.
   
   FE folding: `signbit(...)` = 0. BE: 1.
   
   ```
   SET enable_sql_cache = false
   
   SELECT signbit(ceil(CAST(-0.5 AS DOUBLE))) AS fe, signbit(ceil(d1)) AS be 
FROM t
   
   +------+------+
   | fe   | be   |
   +------+------+
   |    0 |    1 |
   +------+------+
   
   SET debug_skip_fold_constant = true
   
   SELECT signbit(ceil(CAST(-0.5 AS DOUBLE)))
   
   +-------------------------------------+
   | signbit(ceil(CAST(-0.5 AS DOUBLE))) |
   +-------------------------------------+
   |                                   1 |
   +-------------------------------------+
   ```
   
   - **FE constant folding**: all arguments are literals, so Nereids folds the 
call during planning. Check: EXPLAIN shows the literal in place of the call: 
`final projections: FALSE, signbit(ceil(d1[#1]))`
   - **BE execution**: the arguments are columns (or `SET 
debug_skip_fold_constant = true`), so BE computes the call. Check: EXPLAIN 
keeps the call.
   
   ### What You Expected?
   
   FE folding and BE give the same sign of zero, so `signbit` agrees.
   
   ### How to Reproduce?
   
   Deployment: single FE + single BE, default session variables.
   
   ```sql
   CREATE TABLE t(id INT, d1 DOUBLE)
     DISTRIBUTED BY HASH(id) BUCKETS 1 PROPERTIES('replication_num' = '1');
   INSERT INTO t VALUES (1, -0.5);
   
   SET enable_sql_cache = false;
   SELECT signbit(ceil(CAST(-0.5 AS DOUBLE))) AS fe, signbit(ceil(d1)) AS be 
FROM t;
   SET debug_skip_fold_constant = true;
   SELECT signbit(ceil(CAST(-0.5 AS DOUBLE)));
   ```
   
   ### Anything Else?
   
   FE converts the double to `BigDecimal` (through `DecimalV3Literal`), which 
has no negative zero; BE calls the C library `ceil`, which returns -0.
   
   - FE: 
[fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java#L404-L408](https://github.com/apache/doris/blob/4.1.4/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java#L404-L408)
 — `ceil(DoubleLiteral)`: through `BigDecimal`
   - BE: 
[be/src/exprs/function/round.h#L255-L258](https://github.com/apache/doris/blob/4.1.4/be/src/exprs/function/round.h#L255-L258)
 — `roundWithMode`: C `floor`/`ceil`
   
   Found with AI assistance.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to