morningman commented on PR #68711:
URL: https://github.com/apache/doris/pull/68711#issuecomment-5978577014
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68711
commit: d847f20e82a53d64f2afc8eebca4307b42026e85
base: 0dcd2a31a7bb00ba9a817c2600f64e770efea54d
reviewed_at: 2026-10-04T17:36+08:00
reviewer: morningman
model: claude-fable-5-1
effort: max
findings: {blocker: 0, major: 0, minor: 1, nit: 3}
rounds: 1
converged: true
```
**Notes for maintainers**
- Nothing was built or executed for this review: the BE unit tests, the
fluss-scanner JUnit suites (including the new in-JVM-cluster FIFO test), the 17
`external_table_p0/fluss` regression suites and the benchmark numbers are the
author's reports. Read-only checks that did run: clang-format 16 (zero
replacements), `build-support/check-build-hygiene.sh` (pass), a 120-column scan
of the changed Java files.
- Residual risks are the two CI-bot threads still open at this head, not
re-raised here: an `Error` on a background closer thread
(`fe/be-java-extensions/fluss-scanner/src/main/java/org/apache/doris/fluss/FlussConnectionCloser.java:117-123`)
and remote-log downloads still in flight when a bounded range is given back
(`fe/be-java-extensions/fluss-scanner/src/main/java/org/apache/doris/fluss/FlussJniScanner.java:386-388`).
- The only defect found (F-01 in the local documents) is pre-existing, not a
regression: `FlussJniScanner.closeQuietly` catches `Exception` only, so an
`Error` from the fluss reader's `close()` skips the lease hand-back; the PR's
own OOME hardening makes it worth closing in the same change.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
