airborne12 commented on code in PR #68661:
URL: https://github.com/apache/doris/pull/68661#discussion_r4193579704
##########
be/src/exprs/function/match.cpp:
##########
@@ -241,9 +351,12 @@ inline std::vector<segment_v2::TermInfo>
FunctionMatchBase::analyse_data_token(
auto reader =
doris::segment_v2::inverted_index::InvertedIndexAnalyzer::create_reader(
analyzer_ctx->char_filter_map);
reader->init(str_ref.data, (int)str_ref.size, true);
- data_tokens =
+ auto element_tokens =
doris::segment_v2::inverted_index::InvertedIndexAnalyzer::get_analyse_result(
reader, analyzer_ctx->analyzer.get());
+ for (auto& token : element_tokens) {
Review Comment:
Confirmed with
`FunctionMatchTest.null_array_elements_do_not_match_hidden_payload`: before the
fix, all six MATCH variants treated the hidden `alpha` payload of NULL array
elements as a match. Commit `fa13da76864` passes the element null map through
the fallback and skips NULL elements. The regression changed from RED to GREEN;
`GLIBC_COMPATIBILITY=OFF ./run-be-ut.sh --run --filter="FunctionMatchTest.*" -j
96` passes 32/32 tests, and the BE ASAN build passes with the same local
setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
