github-actions[bot] commented on code in PR #68698:
URL: https://github.com/apache/doris/pull/68698#discussion_r4213935182
##########
build.sh:
##########
@@ -456,21 +455,10 @@ if [[ ! -f
"${DORIS_THIRDPARTY}/installed/lib/${LAST_THIRDPARTY_LIB}" ||
! -f "${DORIS_THIRDPARTY}/installed/include/paimon_rust/paimon.h" ||
! -s "${DORIS_THIRDPARTY}/installed/lib64/libpaimon_c.a" ||
! -s "${DORIS_THIRDPARTY}/installed/include/paimon_rust/paimon.h" ||
- -e "${DORIS_THIRDPARTY}/installed/lib64/.paimon-installing" ]] ||
- ! lance_c_install_is_current "${DORIS_HOME}/thirdparty"
"${DORIS_THIRDPARTY}/installed"; then
- # External trees can be partially updated or pinned to another revision.
Preserve
- # the existing prefix unless their build inputs can produce the requested
Lance version.
- for input in build-thirdparty.sh download-thirdparty.sh vars.sh
lance-install.sh patches/lance-c-foyer.patch; do
- if [[ ! -f "${DORIS_THIRDPARTY}/${input}" || ! -r
"${DORIS_THIRDPARTY}/${input}" ]]; then
- echo "Third-party dependencies require a rebuild, but ${input} is
missing or unreadable." >&2
- echo "Refresh the compilation image or set DORIS_THIRDPARTY to a
complete third-party source tree." >&2
- exit 1
- fi
- done
- if ! expected_lance_fingerprint="$(lance_c_install_fingerprint
"${DORIS_HOME}/thirdparty")" ||
- ! rebuild_lance_fingerprint="$(lance_c_install_fingerprint
"${DORIS_THIRDPARTY}")" ||
- [[ "${rebuild_lance_fingerprint}" != "${expected_lance_fingerprint}"
]]; then
- echo "Lance rebuild sources do not match this checkout; installed
dependencies have been preserved." >&2
+ -e "${DORIS_THIRDPARTY}/installed/lib64/.paimon-installing" ]]; then
Review Comment:
[P2] Preserve Lance install-completeness checks when removing the
fingerprint. A targeted `build-thirdparty.sh lance_c` can be interrupted just
after `build_lance_c` deletes `installed/include/lance`; the previous archive
and every other sentinel remain, so this gate skips repair and the next BE
build fails to find `lance/lance.h`. It also accepts a zero-byte archive. Check
both headers and the archive for nonempty contents, and use an installing
marker spanning header and archive publication to catch mixed pairs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
