HappenLee commented on code in PR #68243:
URL: https://github.com/apache/doris/pull/68243#discussion_r4216043448
##########
be/src/exprs/aggregate/aggregate_function_topn.h:
##########
@@ -184,7 +185,7 @@ struct AggregateFunctionTopNData {
writer.StartObject();
for (int i = 0; i < std::min((int)counter_vector.size(), top_num);
i++) {
const auto& element = counter_vector[i];
- writer.Key(element.second.c_str());
Review Comment:
Reviewed. No change is required for this finding in this PR. We accept the
large-key writer limit as a non-blocking limitation for this focused
embedded-NUL truncation fix.
##########
be/src/exprs/aggregate/aggregate_function_topn.h:
##########
@@ -184,7 +185,7 @@ struct AggregateFunctionTopNData {
writer.StartObject();
for (int i = 0; i < std::min((int)counter_vector.size(), top_num);
i++) {
const auto& element = counter_vector[i];
- writer.Key(element.second.c_str());
Review Comment:
Reviewed. No change is required for this finding in this PR. We accept this
as non-blocking and will keep invalid-UTF-8 handling unchanged here, keeping
the PR focused on preserving embedded NUL bytes in topn() JSON keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
