github-actions[bot] commented on code in PR #68812:
URL: https://github.com/apache/doris/pull/68812#discussion_r4226939739
##########
regression-test/suites/mtmv_p0/ivm/test_ivm_rewrite_projection.groovy:
##########
@@ -16,6 +16,11 @@
// under the License.
suite("test_ivm_rewrite_projection") {
+ // The order_qt_rewrite_projection_base query below must read the base
table instead of being
+ // answered by the MV, so transparent rewrite is off by default and
enabled only around the
+ // rewrite-hit check. A SET_VAR hint cannot do this: the switch is read
during
Review Comment:
[P3] Correct the `SET_VAR` timing explanation. `LogicalPlanBuilder` calls
`SelectHintSetVar.setVarOnceInSql` while parsing the query, and
`NereidsPlanner` calls `collectAndLockTable` afterward; `ExplainCommand` also
reads the effective flag before planning this memo-plan check. Thus the hint is
applied before the rewrite switch is read, contrary to this comment. The
explicit session settings still work, but this rationale will mislead future
test changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
