github-actions[bot] commented on code in PR #67273:
URL: https://github.com/apache/doris/pull/67273#discussion_r4228256640
##########
be/src/format/parquet/vparquet_reader.cpp:
##########
@@ -343,6 +343,12 @@ Status ParquetReader::_open_file() {
: _file_reader;
}
+ // A range size of -1 means reading from the range start to the end of the
file. Resolve it
+ // after opening the file so row-group filtering can use the actual range
boundary.
+ if (_range_size == -1) {
Review Comment:
[P2] Initialize range members before testing the unknown-size sentinel. The
two schema-only `ParquetReader` constructors (lines 148-188) leave
`_range_size` and `_range_start_offset` uninitialized. `fetch_table_schema`
constructs one and calls `init_schema_reader()`, which reaches this new
comparison in `_open_file()`, so ordinary schema inference reads an
indeterminate value; if it happens to equal `-1`, the subtraction also uses an
indeterminate offset. Initialize both members from `range` in those
constructors (or at declaration).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
