CalvinKirs commented on PR #68823: URL: https://github.com/apache/doris/pull/68823#issuecomment-6077827198
### Local `doris-repo-review` result — 2026-10-09 Reviewed commit: `3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3` (target: `master`). **Verdict: APPROVE** — 0 Blocker, 0 Major, 2 Minor. The review converged in one round and covered all three changed files. - **Minor — follower coverage:** The [new `SHOW FRONTENDS` loop](https://github.com/apache/doris/blob/3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3/regression-test/suites/auth_p0/test_http_rest_v1_auth.groovy#L92-L95) can pass on a single-FE cluster without exercising the follower forwarding path. A dedicated two-FE test or an explicit follower assertion would close this gap. - **Minor — grant replay:** After `GRANT admin`, [direct Basic-auth requests to every alive FE](https://github.com/apache/doris/blob/3d30c1f55bf9048dac7e49fc7f2a7bb14f2bf7b3/regression-test/suites/auth_p0/test_http_rest_v1_auth.groovy#L92-L99) may reach another follower before it replays the grant, causing an intermittent business-code 401 unrelated to this fix. Synchronize each target follower before its HTTP request. The production forwarding path has no blocking finding: HTTP contexts omit the absent MySQL capability, the master restores its existing default, and real MySQL clients retain their negotiated flags. Before the final rebase, 21 targeted FE unit tests and Checkstyle passed. This read-only review did not rerun tests, and the multi-FE HTTP regression has not run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
