github-actions[bot] commented on code in PR #68815:
URL: https://github.com/apache/doris/pull/68815#discussion_r4229152123
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -487,6 +487,9 @@ struct TVectorSearchParams {
3: optional i64 top_k
4: optional i64 offset
5: optional TVectorMetric metric
+ // FLOAT bounds: inclusive lower and exclusive upper.
+ 6: optional double distance_lower_bound
+ 7: optional double distance_upper_bound
Review Comment:
[P1] Guard bounded searches across BE rolling upgrades. These new optional
fields are the only distance filter, but `vector_search()` still sends schema
version 1. A pre-change BE accepts that version, skips fields 6/7, and runs an
unbounded nearest search; the FE's old-BE check only covers additional
projected types. For example, `distance_upper_bound=16` can return rows at
distance 16 or above. Use a range-specific request version that old BEs reject,
or require range-capable BEs before dispatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
