github-actions[bot] commented on code in PR #16680:
URL: https://github.com/apache/doris/pull/16680#discussion_r1104724983
##########
be/src/vec/olap/vgeneric_iterators.h:
##########
@@ -80,10 +80,7 @@ class VMergeIteratorContext {
VMergeIteratorContext& operator=(const VMergeIteratorContext&) = delete;
VMergeIteratorContext& operator=(VMergeIteratorContext&&) = delete;
- ~VMergeIteratorContext() {
- delete _iter;
- _iter = nullptr;
- }
+ ~VMergeIteratorContext() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~VMergeIteratorContext() = default;
```
##########
be/src/vec/olap/vertical_merge_iterator.h:
##########
@@ -143,10 +143,7 @@ class VerticalMergeIteratorContext {
VerticalMergeIteratorContext& operator=(const
VerticalMergeIteratorContext&) = delete;
VerticalMergeIteratorContext& operator=(VerticalMergeIteratorContext&&) =
delete;
- ~VerticalMergeIteratorContext() {
- delete _iter;
- _iter = nullptr;
- }
+ ~VerticalMergeIteratorContext() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~VerticalMergeIteratorContext() = default;
```
##########
be/src/vec/olap/vgeneric_iterators.cpp:
##########
@@ -343,12 +344,9 @@ class VUnionIterator : public RowwiseIterator {
// Iterators' ownership it transferred to this class.
// This class will delete all iterators when destructs
// Client should not use iterators anymore.
- VUnionIterator(std::vector<RowwiseIterator*>& v) :
_origin_iters(v.begin(), v.end()) {}
+ VUnionIterator(std::vector<RowwiseIteratorUPtr>&& v) :
_origin_iters(std::move(v)) {}
- ~VUnionIterator() override {
- std::for_each(_origin_iters.begin(), _origin_iters.end(),
- std::default_delete<RowwiseIterator>());
- }
+ ~VUnionIterator() override {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~VUnionIterator() override = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
