hubgeter opened a new pull request, #68822:
URL: https://github.com/apache/doris/pull/68822
### What problem does this PR solve?
Issue Number: N/A
Related PR: #68532
Problem Summary:
`branch-4.1` already uses `TIcebergTableSink` field id 19 for
`static_partition_null_keys`, while master used the same id for
`nan_count_field_ids`. Keep the shared field aligned across branches: reserve
19 for `static_partition_null_keys` (same definition as 4.1) and move
`nan_count_field_ids` to 20. Both fields are still bound by name in the
generated code, so no caller changes are needed.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- `thrift -I gensrc/thrift --gen cpp gensrc/thrift/DataSinks.thrift`
succeeds, and the generated `TIcebergTableSink` still exposes
`static_partition_null_keys` (set<string>) and `nan_count_field_ids`
(vector<int32_t>) by name.
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
