github-actions[bot] commented on code in PR #68797:
URL: https://github.com/apache/doris/pull/68797#discussion_r4230510967
##########
be/src/common/config.cpp:
##########
@@ -1228,7 +1228,7 @@ DEFINE_Validator(variant_storage_parse_mode,
[](const int config) -> bool { return config >= 0 && config
<= 2; });
// block file cache
-DEFINE_Bool(enable_file_cache, "false");
+DEFINE_Bool(enable_file_cache, "true");
Review Comment:
[P2] Validate the cache block size before enabling it by default. A coupled
BE that previously ran with `enable_file_cache=false` and
`file_cache_each_block_size=0` now enters `ExecEnv::init_file_cache_factory()`,
where `s3_write_buffer_size % file_cache_each_block_size` executes before
`validate_hdfs_write_batch_buffer_size()` rejects nonpositive sizes. Startup
terminates with SIGFPE instead of reporting the invalid setting. Move the
positive-size check ahead of the modulo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
