englefly commented on code in PR #67675:
URL: https://github.com/apache/doris/pull/67675#discussion_r4236019181
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java:
##########
@@ -147,6 +147,11 @@ public Boolean
visitPhysicalLazyMaterializeOlapScan(PhysicalLazyMaterializeOlapS
@Override
public Boolean visitPhysicalRelation(PhysicalRelation scan,
PushDownContext ctx) {
+ // Variant hash keys use canonical equality. The scalar RF
implementations do not
+ // support that encoding; a cast to a supported scalar type can still
produce an RF.
+ if (ctx.srcExpr.getDataType().isVariantType() ||
ctx.probeExpr.getDataType().isVariantType()) {
+ return false;
Review Comment:
这个判断因该提前 到 下推以前.
RuntimeFilterGenerator 会生成ctx(生成点
RuntimeFilterPushDownVisitor.PushDownContext.createPushDownContext).
有下面3处是下推的起点
RuntimeFilterGenerator.visitPhysicalHashJoin
visitPhysicalNestedLoopJoin
generateRuntimeFilterForSetOperation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
