github-actions[bot] commented on code in PR #68786:
URL: https://github.com/apache/doris/pull/68786#discussion_r4236836034
##########
be/src/format/orc/vorc_reader.h:
##########
@@ -654,6 +654,18 @@ class OrcReader : public TableFormatReader, public
RowPositionProvider {
continue;
}
}
+ if (data->hasNulls && !data->notNull[i]) {
+ continue;
+ }
+ // Check the UTC epoch before packing: ORC permits years outside
Doris's 0001-9999 range.
+ static constexpr int64_t MIN_SECONDS = -62135596800LL;
Review Comment:
[P2] Accept UTC year zero in V1 ORC TIMESTAMPTZ scans. The new `MIN_SECONDS`
is 0001-01-01T00:00:00Z, but Doris and the V2 ORC reader accept
0000-01-01T00:00:00Z (`-62167219200`). With `enable_file_scanner_v2=false`, an
Iceberg ORC `TIMESTAMP_INSTANT` in that interval reaches this V1 decoder and
returns `DataQualityError` instead of a row. Use the Doris year-zero lower
epoch and cover this boundary in V1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
