yiguolei commented on code in PR #68804:
URL: https://github.com/apache/doris/pull/68804#discussion_r4237410745
##########
be/src/exec/scan/olap_scanner.cpp:
##########
@@ -475,6 +475,9 @@ Status OlapScanner::_init_tablet_reader_params(
const bool no_runtime_filters = _total_rf_num == 0;
const bool segment_limit_enabled =
_state->enable_segment_limit_pushdown();
const bool storage_no_merge =
olap_scan_local_state->_storage_no_merge();
+ // Storage TopN compares key columns that TabletReader prepares only
for DUP and
+ // merge-on-write tablets, so a MOR table read as DUP cannot use it.
+ const bool storage_topn_supported = storage_no_merge &&
!read_mor_as_dup;
Review Comment:
除了这个修复之外，我们还需要做一下工作：如果底层因为这个会挂掉的话，我们应该在底层相关代码那里加一些检查，提前报错。好的代码不应该假定生层传递的参数永远是对的，我们得保证及时是错的时候，我们也能正常处理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
