mrhhsg commented on PR #68032:
URL: https://github.com/apache/doris/pull/68032#issuecomment-6106601131
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68032
commit: 9297179fffa84ec325d62ec7f873e9654018ebc2
base: 157e03eeb16deb8a84ae58d9bed721f56f8fedb3
reviewed_at: 2026-10-11T15:18+08:00
reviewer: mrhhsg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 6, nit: 6}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-07 (observability, Regression: yes)
`fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadRuntimeStatusMgr.java:183-188`：等待另一个
BE 的 final report 时，已收到的参与者统计可能被 TTL cleaner 删除，导致审计延迟并漏计。非 SQL 结果/事务数据错误，按
Minor 保留；本轮纠正了旧评审“仅延迟、统计不变”的结论。
- F-01/F-03/F-05：生产 vault resolver、store 构造/cloud validation、非轮换写失败后的
close/ready 状态仍缺少精确测试；已有 mock 不能替代这些 gate。
- F-04 `be/src/exec/spill/spill_file_writer.cpp:208-216`：从未调用底层 close 的失败
part 仍执行一次不必要的同步 LIST，可作为后续性能改进。
- F-06：所有模式的 SHOW DATA 均依赖 master，这是当前 PR 描述明确声明的取舍，不再是未声明回归。disk report 与
restart heartbeat 没有 generation fencing，暂态陈旧值按 best-effort 快照限制处理。
- 已覆盖 64/64 文件，lead 与两位 coverage reviewer 均为 gpt-6-astra /
xhigh；只做静态审查，未编译或运行测试。崩溃后 process-local 计数丢失、无界远端删除重试/关闭延迟仍是已有已接受限制，并未被本回执标记为修复。
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
