morningman commented on PR #68921: URL: https://github.com/apache/doris/pull/68921#issuecomment-6118403930
Addressed in 62f9b3c8cea. - BE UT: `PaimonWriteBackendTest.AdvertisesPaimonWriteExecVersion` asserted that the Paimon write version (16) is the newest execution version, which this PR's version 17 broke. It now checks that the newest version is at least 16 and that the version after the newest is rejected. - `test_iceberg_write_partition_distribution` pins `parallel_pipeline_task_num = 8`, so a fuzzy session cannot run it with one or two writers (see the per-writer cap thread). Per finding: - SPI API major (P1): not bumped; the connector SPI is unreleased and the surface baseline is refreshed. - Version pinning (P2): not changed; every connector capability gate reads the live `be_exec_version` at plan time, and an older backend rejects the function, so the INSERT fails without committing. - Per-writer cap (P1): the cap applies to each writer's share, as in branch-4.x; the release note and the description now say so, and the suite pins its writer count. - NaN hashing (P2): not changed; the route reuses the existing `IcebergInsertPartitionFunction`, and the cost is extra files in one partition, not misplaced rows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
