morningman commented on code in PR #68919:
URL: https://github.com/apache/doris/pull/68919#discussion_r4244952614
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/check/CheckCastTest.java:
##########
@@ -145,6 +145,58 @@ public void testCastBetweenVariantTypes() {
true));
}
+ @Test
+ public void testCastToConnectorComputeVariantMatrix() {
+ // A connector Variant column (e.g. a Paimon VARIANT) is written
through the V2 compute
+ // carrier, which encodes scalar, JSON and Variant values and arrays
of them. CheckCast is the
+ // analysis-time gate of that contract in both cast modes, so an
unsupported source is
+ // rejected at analysis instead of being handed to the BE.
+ List<DataType> supportedSources = Lists.newArrayList(
Review Comment:
Follow-up: the separate fix is #68935. It admits UUID in
`VariantType.isSupportedComputeV2CastSource`, adds the UUID and `ARRAY<UUID>`
cases in both cast modes to `CheckCastTest`, and adds UUID rows to
`test_paimon_write_variant`, which fails on master at that INSERT and passes
with the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
