jacktengg commented on PR #68830:
URL: https://github.com/apache/doris/pull/68830#issuecomment-6119504214
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68830
commit: 87f272818d3bc6fcbb73f1496dd0974dc6fcaecf
base: ff89892be2565b36b2d6fa3b43a8a53ac4e03dc8
reviewed_at: 2026-10-12T15:11+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- Minor F-03:
`regression-test/suites/query_p0/sql_functions/datetime_functions/test_composite_time_extract.groovy:85-86`
— update the PR description/release note: current code adds TIME signatures
and literal recognition, while nonliteral strings retain historical DATETIME
coercion; string signatures/fallback are removed. Current test counts are 3
unit tests and 81 regression tags.
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/HourMinute.java:70`
— the existing [negative-zero formatter
thread](https://github.com/apache/doris/pull/68830#discussion_r4244651493)
remains applicable. It is excluded from new finding counts only by
existing-comment deduplication, not considered fixed.
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/SecondMicrosecond.java:70`
— the existing [maximum TIME fractional-boundary
thread](https://github.com/apache/doris/pull/68830#discussion_r4244651488)
remains applicable and is likewise excluded only as an existing comment.
- Review covered all 7 changed files with two qualified coverage reviewers
and converged in round 1. No builds or tests were run during review; prior
implementation logs and generated regression output were inspected. Earlier
automatic string-fallback findings are obsolete after that mechanism was
removed.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
