github-actions[bot] commented on code in PR #16812:
URL: https://github.com/apache/doris/pull/16812#discussion_r1108097126
##########
be/src/olap/tablet.cpp:
##########
@@ -1807,29 +1798,41 @@ Status
Tablet::_read_cooldown_meta(io::RemoteFileSystem* fs, int64_t cooldown_re
return Status::OK();
}
-Status Tablet::_write_cooldown_meta(io::RemoteFileSystem* fs, UniqueId
cooldown_meta_id,
- RowsetMeta* new_rs_meta) {
+Status Tablet::write_cooldown_meta(const
std::shared_ptr<io::RemoteFileSystem>& fs,
+ UniqueId cooldown_meta_id,
+ const std::vector<RowsetMetaSharedPtr>&
to_adds,
+ const std::vector<RowsetMetaSharedPtr>&
to_deletes) {
+ std::set<Version> to_delete_map;
+ for (auto& rs_meta : to_deletes) {
+ to_delete_map.emplace(rs_meta->version());
+ }
std::vector<RowsetMetaSharedPtr> cooldowned_rs_metas;
{
std::shared_lock meta_rlock(_meta_lock);
for (auto& rs_meta : _tablet_meta->all_rs_metas()) {
if (!rs_meta->is_local()) {
+ if (to_delete_map.contains(rs_meta->version())) {
+ continue;
Review Comment:
warning: no member named 'contains' in 'std::set<doris::Version>'
[clang-diagnostic-error]
```cpp
contains(rs_meta->version())) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
