github-actions[bot] commented on code in PR #68853:
URL: https://github.com/apache/doris/pull/68853#discussion_r4288544128
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/load/NereidsStreamLoadPlanner.java:
##########
@@ -269,6 +270,7 @@ public TPipelineFragmentParams plan(TUniqueId loadId, int
fragmentInstanceIdInde
TPipelineFragmentParams params = new TPipelineFragmentParams();
params.setProtocolVersion(PaloInternalServiceVersion.V1);
+
params.setS3Resources(ThriftPlansBuilder.collectS3Resources(connectContext));
Review Comment:
[P2] Refresh resources when reusing prepared group-commit plans
This snapshots the S3 properties into fragment parameters that
`GroupCommitPlanner` retains across EXECUTEs. A reachable case is a scalar
generated column `n BIGINT AS (ELEMENT_AT(TO_FILE('r', uri), 'size'))` with
prepared `INSERT INTO t(id, uri) VALUES (?, ?)` and
`enable_group_commit_full_prepare`/group commit enabled. After the first
execution, rotate `r`'s credentials with `ALTER RESOURCE` and execute again:
planner reuse checks only the table ID/schema version, and
`refreshExecPlanFragmentParams()` refreshes only `query_globals`, so the second
request still sends the old `s3_resources` and TO_FILE can fail with the
revoked credentials. Clearing `ConnectContext.s3Resources` does not refresh
this cached copy. Re-resolve the named resources for each cached execution or
invalidate/rebuild resource-dependent plans, and cover credential rotation
through this prepared group-commit route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
