Gabriel39 opened a new pull request, #69189:
URL: https://github.com/apache/doris/pull/69189

   ### What problem does this PR solve?
   
   Follow-up to #68746. Remove `result_file_name.h` and inline its single 
formatting expression at both call sites: the OUTFILE and TVF writers. File 
naming behavior is unchanged.
   
   Replace the helper-only unit test with an end-to-end regression covering 
both writers, CSV/Parquet/ORC, default and explicit padding widths, invalid 
values, custom OUTFILE suffixes, and rollover beyond index 9. The test checks 
actual object names, verifies minimum-width semantics and lexical ordering, 
reads the exported data back, and cleans up its unique object prefix.
   
   ### Validation
   
   - The new `test_result_file_name_padding` regression passed locally against 
a master build containing #68746. A mutation that forces padding to zero fails 
the filename assertion.
   - Both inlined C++ formatting expressions passed the five original boundary 
scenarios in a standalone harness.
   - clang-format 16 and `git diff --check` passed.
   - The modified full BE binary has not been rebuilt locally; the new 
regression's local run used the existing master binary. Full build and 
regression validation will run in CI.
   
   ### Release note
   
   None; no behavior change.
   
   ### Check List (For Author)
   
   - [x] Regression test
   - [x] No behavior change
   - [x] No documentation change needed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to