pengxiangyu commented on code in PR #16803:
URL: https://github.com/apache/doris/pull/16803#discussion_r1108308600
##########
be/src/olap/tablet.cpp:
##########
@@ -1768,7 +1765,10 @@ Status Tablet::_cooldown_data(const
std::shared_ptr<io::RemoteFileSystem>& dest_
UniqueId cooldown_meta_id = UniqueId::gen_uid();
// upload cooldowned rowset meta to remote fs
- RETURN_IF_ERROR(_write_cooldown_meta(dest_fs.get(), cooldown_meta_id,
new_rowset_meta.get()));
+ st = _write_cooldown_meta(dest_fs.get(), cooldown_meta_id,
new_rowset_meta.get());
Review Comment:
Why remove RETURN_IF_ERROR？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
