github-actions[bot] commented on code in PR #68862:
URL: https://github.com/apache/doris/pull/68862#discussion_r4304686025
##########
fe/pom.xml:
##########
@@ -399,12 +393,12 @@ under the License.
<antlr4.version>4.13.1</antlr4.version>
<joda.version>2.8.1</joda.version>
<project.scm.id>github</project.scm.id>
- <!-- Spring Boot 3.5.16 manages fixed Spring LDAP 3.3.8, Spring Data
3.5.13,
- Micrometer 1.15.12, and Logback 1.5.34 releases for their 2026
advisories. -->
- <spring.version>3.5.16</spring.version>
- <!-- Spring Framework 6.2.19 fixes the June 2026 security advisory
set, including
- CVE-2026-41848; keep the explicit framework BOM aligned with that
release. -->
- <spring-framework.version>6.2.19</spring-framework.version>
+ <!-- Boot 3.5 and Framework 6.2 have ended OSS support. Boot 4.1
manages the
+ supported Spring LDAP and Spring Data generations. -->
+ <spring.version>4.1.1</spring.version>
Review Comment:
[P2] Migrate the servlet encoding properties when upgrading Boot
`HttpServer.start()` still sets
`server.servlet.encoding.{charset,enabled,force}`, whereas Boot 4 binds these
filter settings under
[`spring.servlet.encoding`](https://raw.githubusercontent.com/spring-projects/spring-boot/v4.1.1/module/spring-boot-servlet/src/main/java/org/springframework/boot/servlet/autoconfigure/ServletEncodingProperties.java).
The old `force=true` is therefore ignored and response forcing defaults to
false. This changes production `/metrics`: `MetricsAction` sets `text/plain`
and writes through `response.getWriter()`, for which Jetty chooses ISO-8859-1.
In cloud mode, supported Unicode database/table names emitted by
`visitCloudTableStats()` become `?`, losing label identities and potentially
merging series. Rename the encoding keys in `HttpServer.start()` and cover a
non-ASCII servlet-writer response using its production configuration; the added
fixture starts a different application and only checks ASCII/JSON payloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
