morningman opened a new pull request, #4360: URL: https://github.com/apache/doris-website/pull/4360
Selecting Why Doris → Benchmarks from Chinese documentation inherited `/zh-CN/`, although the benchmark content was English and its language controls were hidden. Documentation and community pages also replaced the full footer with a compact copyright notice. Both desktop and mobile Benchmark links now open `/why-doris/benchmarks` in the English locale. Page language controls remain available on fallback pages and offer the existing translations. The full footer now renders on documentation and community pages, using one shared English configuration and `lang="en"` regardless of the page locale. ## Validation - All 18 tests passed in `marketing-pages.test.cjs`, `locale-registry.test.cjs`, and `doc-navigation.test.cjs`, including new navigation and fallback-language regressions. - Scoped TypeScript check and `git diff --check` passed. - A small native Docusaurus fixture built successfully for English, Chinese, and Japanese using the production components and locale dictionaries. It covers Dev/4.x documentation, community pages, and the benchmark page; a full documentation build was not run. - Browser checks passed at 1440 px and 390 px across all three locales: 18 documentation/community route and viewport combinations, English benchmark entry, English/Japanese round trips, query/fragment preservation, refresh, fallback Chinese language controls, and English footer content before and after hydration. No horizontal overflow, page errors, or hydration errors occurred. Desktop and mobile screenshots were inspected. - The shared footer configuration preserves all existing links, logo settings, and copyright content. ## Review conclusions - Goal: Benchmark navigation enters English, manual page-language switching remains available, and documentation/community pages show the full English footer. - Scope: Changes stay within shared navigation, language controls, footer configuration/rendering, and regression tests. - Information architecture: Documentation versions, localized content, sidebars, blog, and community organization remain consistent. - Routing: Existing page URLs and anchors are preserved. Only the Benchmark menu destination changes; no redirects or sidebar updates are required. - Frontend: Desktop and mobile use the same menu data. The footer retains existing styling and semantic theme tokens, adds an English language attribute, and removes its post-hydration replacement. - Coverage: Targeted tests, scoped type checking, production fixture builds, and browser interactions cover the changed behavior. Full-site compilation remains for CI. - Other issues: No additional correctness, accessibility, SEO, or maintainability issues found in the changed scope. ## Versions - [x] dev - [x] 4.x - [x] 3.x - [x] 2.1 or older (not covered by version/language sync gate) The shared navigation and footer apply across documentation versions. ## Languages - [x] Chinese - [x] English - [x] Japanese The footer deliberately uses English in every locale; document translations need no content changes. ## Docs Checklist - [x] Checked by AI - [x] Test Cases Built - [x] Updated required version and language counterparts, or explained why not - [x] If only one language changed, confirmed whether source/translation counterparts need sync -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
