mrhhsg commented on PR #68032:
URL: https://github.com/apache/doris/pull/68032#issuecomment-6258289445
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68032
commit: 6d43a1789ebc6421c550020dff4e6a081bde3dd7
base: 157e03eeb16deb8a84ae58d9bed721f56f8fedb3
reviewed_at: 2026-10-19T10:21+08:00
reviewer: mrhhsg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 5, nit: 13}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-07 (observability, undeclared behaviour change; Regression: yes)
`fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadRuntimeStatusMgr.java:183-188`
— the new ordinary-query final-report wait can let already acknowledged BE
contributions expire, permanently understating existing scan/CPU/local-spill
and remote-spill statistics in audit logs/table, including queries without S3
enabled. Retained as Minor after an independent qualified severity challenge:
traced consumers are best-effort diagnostics, not authoritative
business/transaction, quota/admission or cleanup inputs; audit-table diagnostic
aggregations can nevertheless be wrong. Pin/snapshot received contributions and
add an aged-final/delayed-final cleanup-cycle test.
- `be/src/common/config.cpp:1709-1712` — incomplete MPU cleanup requires the
operator-configured AbortIncompleteMultipartUpload lifecycle rule; ordinary
prefix deletion does not remove incomplete uploads. No real-provider lifecycle
timing or cleanup guarantee was validated by this static review.
- `fe/fe-core/src/main/java/org/apache/doris/qe/FEOpExecutor.java:89-91` —
the known execute/cancel participant-snapshot overlap remains despite its
resolved thread; old-serving mixed-version UI normalization and process-local
report epoch/failover limitations also remain documented. Deduplication and
PASS do not mean these residuals were fixed.
- Fresh full-PR coverage: 67/67 changed files, one converged round; lead,
both full-coverage reviewers and the independent F-07 challenger all actually
used explicitly selected gpt-6-astra / xhigh. This is not a relabelled tiered
run. No build, UT, regression, SQL, concurrency reproducer or benchmark was
run; this receipt is not required-CI success or a human Apache approval.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
