yujun777 commented on PR #68648: URL: https://github.com/apache/doris/pull/68648#issuecomment-6259086494
The union-compensation branch added in this PR now has end-to-end coverage, and the review thread about the unreachable compensation read is addressed: - `81eb6b5f412` removes `mvPartitionsToReadThrough()` / `isPctTable()` and the `mvPartitionsToRemove` parameter chain. `getMTMVCanRewritePartitions()` already returns no partition when a PCT table has a default list partition, so that branch cannot be reached. - `e450eef95aa` adds `stale_fractional_union` to `mtmv_p0/test_mtmv_base_partition_read_scope`: a `LIST(ts)` `DATETIME(3)` partition goes stale after the refresh, the plan is asserted to be the union, and the golden checks the compensated totals. The key must be written at the column's scale (`.123`); rounding it to the second reads none of the partition and drops the row. Together with the existing `sync_window_narrowed` case (which checks that a `LIST(d, region)` table compensated from the base branch returns every key exactly once), both compensation-read shapes this PR touches now have a regression that can fail without the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
