eldenmoon opened a new pull request, #69260:
URL: https://github.com/apache/doris/pull/69260
cherry-pick #68447
Adapted to branch-4.2, which still has the V1 Variant writer and the
`enable_variant_v2` FE
switch:
- V1 call sites that read the two removed BE configs (`variant_util`,
`function_variant_parse`, `data_type_variant_serde`) now always reject
duplicate paths and
invalid JSON, matching the new V2 default. `ParseConfig` gained
`throw_on_invalid_json`
(default `true`) so the Variant serde keeps reading back values the parser
cannot parse,
like the V2 serde does.
- `duplicate_json_path.groovy`, `column_name.groovy` and
`variant_compute_v2.groovy` keep the
branch-4.2 `enable_variant_v2` gating and the V1/V2 expectations; only the
removed BE config
wrapper is dropped.
- Tests that toggled the removed configs (`variant_util_test`,
`index_storage_test_util`, the
`JsonToVariantOptions::check_duplicate_json_path` initializers) are
updated accordingly.
Tested locally with
`./run-be-ut.sh --run
--filter='VariantUtilTest.*:FunctionVariantParseTest.*:VariantFieldTest.*:ColumnVariantV2Test.*:DataTypeVariantV2Serde*.*:VariantJson*Test.*:VariantColumnWriterReaderTest.*'`
(branch-4.2 code + this pick, RELEASE build): 203 tests ran, 192 passed, 2
skipped, 9 failed.
All 9 failures also happen on branch-4.2 without this change:
- 8 `ColumnVariantV2Test` death tests
(`DefaultRowsUseCanonicalEmptyObjectAndReuseMetadata`,
`InPlaceFilterPrevalidatesInputs`,
`PopBackAndResizeCoverBoundsShrinkAndGrowth`,
`RejectsInvalidBulkOffsetsAndMetadataIds`, `EncodedRowCountInvariant`,
`MetadataIdInvariant`, `TypedConstructionAndNullableInvariant`,
`TypedEncodedInsertMatrixKeepsConstSource`): they use `EXPECT_DEATH`, but
`doris_check_fail` throws an exception instead of aborting, so the
statement never dies.
- `VariantColumnWriterReaderTest.test_nested_iter`:
`_process_nested_columns` returns OK for a
different array offset.
The rewritten regression suites were not run locally (they need a cluster).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
