eldenmoon opened a new pull request, #69259:
URL: https://github.com/apache/doris/pull/69259
cherry-pick #68444
Adapted to branch-4.2:
- `be/test/storage/test_data/segment_flusher_format/*`: the fixtures the
original commit
updates do not exist on branch-4.2 (that test was never backported), so
they stay deleted.
- branch-4.2 still has the V1 variant writer. `VariantColumnWriterImpl` may
own only a V1
writer, so `get_total_data_pages_bytes` dispatches to
`VariantV1ColumnWriter`, which sums
its root, subcolumn and binary writers, instead of dereferencing a null V2
writer.
`VariantSubcolumnWriter` reports 0 before its writer exists.
Tested locally with
`./run-be-ut.sh --run
--filter='VariantColumnWriterReaderTest.*:VariantUtilTest.*'`
(branch-4.2 code + this pick, RELEASE build):
- 77 tests passed, including
`VariantColumnWriterReaderTest.test_write_data_normal`,
`doc_compact_writer_round_trip` and the two writer helpers that now assert
the variant
data page bytes, plus all 21 `VariantUtilTest` tests.
- `VariantColumnWriterReaderTest.test_nested_iter` fails, but it fails on
branch-4.2 without
this change as well (`_process_nested_columns` no longer returns an error
for a different
array offset), so it is not caused by this pick.
The new regression suite
`query_p0/system/test_query_sys_column_data_sizes_variant` was not
run locally (needs a cluster).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
