mrhhsg commented on PR #68279:
URL: https://github.com/apache/doris/pull/68279#issuecomment-6274888109
<!-- autopilot-response -->
Re-checked the full review history at HEAD
`ef01c98e4dcfe07e279fde164037bf539e476dc6`.
**New top-level comments since the previous report** (both are benchmark
payloads and contain no code finding):
- `IC_kwDOBfSlxs8AAAABdgB7TQ` — TPC-DS result on this HEAD.
- `IC_kwDOBfSlxs8AAAABdgHjEg` — ClickBench result on this HEAD.
The other entries are `/review` and `run buildall` commands, two stale
"Codex review failed" notices from 2026-09-22, a local PASS receipt, and TPC-H
/ TPC-DS / ClickBench / coverage payloads; none contains a code finding.
**Previous inline findings — fixed; both threads are resolved and outdated:**
- Sparse-accounting overcount in `segment_iterator.cpp`:
`_get_row_ranges_from_conditions()` derives each stage's delta through
`_count_alive_rows()` (`be/src/storage/segment/segment_iterator.cpp:1162`),
which uses `roaring_bitmap_range_cardinality` against the surviving
`_row_bitmap` instead of the dense min/max envelope.
`DisjointKeyRangesOnlyCountAliveRows`
(`be/test/storage/segment/segment_iterator_key_range_stats_test.cpp:204`)
covers key ranges `{1}` and `{5000}` and asserts `RowsStatsFiltered == 1`.
- Trailing `DROP TABLE` in `point_lookup_zone_map_profile.groovy`: removed;
both tables are dropped only before creation (lines 21 and 161).
**Latest automated review:** the `github-actions` review at this exact HEAD
(2026-10-19T14:50:49Z) reports no new substantiated issue and states that no
previously reported blocking finding remains applicable.
**Validation at this HEAD (fresh local run):**
`SegmentIteratorKeyRangeStatsTest.*` + `SegmentIteratorExprZonemapTest.*` — 31
tests, all passed.
The `CHANGES_REQUESTED` decision dates from the 2026-09-20 automated review;
the author cannot dismiss it. Could a maintainer take another look and clear it
if the remaining concerns are satisfied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
