github-actions[bot] commented on code in PR #69007:
URL: https://github.com/apache/doris/pull/69007#discussion_r4324106439
##########
cloud/test/meta_service_job_test.cpp:
##########
@@ -7274,7 +7274,7 @@ TEST(MetaServiceJobTest, AbortTxnForRelatedRowsetTest4) {
&req, &res, nullptr);
// Should fail because transaction is already aborted
ASSERT_NE(res.status().code(), MetaServiceCode::OK);
- ASSERT_TRUE(res.status().msg().find("rowset has already been
marked as recycled") !=
+ ASSERT_TRUE(res.status().msg().find("recycle rowset key not
found") !=
Review Comment:
[P2] Preserve the publish-path tests' recycled-marker expectation
`AbortTxnForRelatedRowsetTest4` and `AbortJobForRelatedRowsetTest4` commit
the rowset before the first `recycle_tmp_rowsets()` pass, which marks the tmp
metadata with `is_recycled=true`. Their final calls are `commit_txn` and
`finish_tablet_job`: `scan_tmp_rowset` (`meta_service_txn.cpp`) and
`process_compaction_job` (`meta_service_job.cpp`) still reject that marked tmp
rowset with `rowset has already been marked as recycled`. Neither call reaches
the modified `commit_rowset` check, so expecting `recycle rowset key not found`
here and at line 7398 makes both tests fail their message assertion. Restore
the original expectation in these two tests; the new message applies to the
tests that call `commit_rowset` after recycling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
